Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add several missing locales #1411

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Add several missing locales #1411

merged 4 commits into from
Oct 16, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 16, 2018 •
edited
Loading

Add missing locales for the following files:

  • test/test_ar_locale.rb
  • test/test_bg_locale.rb
  • test/test_ca_cat_locale.rb
  • test/test_da_dk_locale.rb
  • test/test_de_at_locale.rb
  • test/test_de_ch_locale.rb
  • test/test_de_locale.rb
  • test/test_ee_locale.rb
  • test/test_en_au_ocker_locale.rb
  • test/test_en_ca_locale.rb
  • test/test_en_gb_locale.rb
  • test/test_en_ind_locale.rb
  • test/test_en_ms_locale.rb
  • test/test_en_nep_locale.rb
  • test/test_en_ng_locale.rb
  • test/test_en_nz_locale.rb
  • test/test_en_pak_locale.rb
  • test/test_en_sg_locale.rb
  • test/test_en_ug_locale.rb
  • test/test_en_us_locale.rb
  • test/test_en_za_locale.rb

@vbrazo vbrazo added the Chores label Oct 16, 2018
@vbrazo vbrazo self-assigned this Oct 16, 2018
@vbrazo vbrazo merged commit ac17fdd into faker-ruby:master Oct 16, 2018
@vbrazo vbrazo deleted the fixtures/add-missing-locales branch October 16, 2018 03:36
@pjohnmeyer pjohnmeyer mentioned this pull request Oct 16, 2018
Merged
@vbrazo vbrazo mentioned this pull request Jul 28, 2019
Merged
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Add several missing locales (faker-ruby#1411)
6291fdf 
* Add missing locales

* Update CHANGELOG.md

* Add missing EN-... locales

* Add locale code to test method names to keep them consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbrazo vbrazo

Labels
Chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vbrazo