Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Lorem namespace #1349

Closed
wants to merge 19 commits into from
Closed

Add Faker::Lorem namespace #1349

wants to merge 19 commits into from

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Aug 28, 2018 •
edited
Loading

Checklist

  • Add Faker::Lorem::Ipsum
  • Add Faker::Lorem::Flickr
  • Add Faker::Lorem::Pixel
  • Add Faker::Lorem::Hipster
  • Deprecate old methods
  • Update docs
  • Add tests for old modules
  • Add tests for new modules

This PR is related to this issue #1318

@vbrazo vbrazo self-assigned this Aug 28, 2018
@vbrazo vbrazo changed the title Add Namespace for Lorem: Faker::Lorem::Ipsum Add Namespace for Lorem - Faker::Lorem::Ipsum Aug 28, 2018
@vbrazo vbrazo added this to the 2.0 milestone Sep 4, 2018
@vbrazo vbrazo mentioned this pull request Sep 4, 2018
Closed
@vbrazo vbrazo changed the title Add Namespace for Lorem - Faker::Lorem::Ipsum Add Namespace for Lorem - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel Sep 27, 2018
@vbrazo vbrazo changed the title Add Namespace for Lorem - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel Add Namespace for Lorem - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel; Faker::Lorem::Hipster Sep 27, 2018
@vbrazo vbrazo changed the title Add Namespace for Lorem - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel; Faker::Lorem::Hipster Lorem Namespacing - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel; Faker::Lorem::Hipster Sep 27, 2018
@vbrazo vbrazo changed the title Lorem Namespacing - Faker::Lorem::Ipsum; Faker::Lorem::Flickr; Faker::Lorem::Pixel; Faker::Lorem::Hipster Add Faker::Lorem namespace Oct 23, 2018
@vbrazo vbrazo changed the base branch from master to v2 January 27, 2019 16:11
@vbrazo vbrazo closed this Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbrazo vbrazo

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@vbrazo