Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new translations to the en-ZA locale #1338

Merged
merged 6 commits into from
Aug 18, 2018
Merged

Add new translations to the en-ZA locale #1338

merged 6 commits into from
Aug 18, 2018

Conversation

bradleymarques
Copy link

Adds more company, city and individual names to the 'en-ZA' locale

vbrazo
vbrazo reviewed Aug 18, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right to me. Probably would be good with a few tests that check these new locales. 🙏

@vbrazo vbrazo changed the title More South African names Add en-ZA locales Aug 18, 2018
@vbrazo vbrazo changed the title Add en-ZA locales Add new translations to the en-ZA locale Aug 18, 2018
@vbrazo vbrazo merged commit edff2e4 into faker-ruby:master Aug 18, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Add new translations to the en-ZA locale (faker-ruby#1338)
d927b51 
* Adds many more South African cities, names and company names

* Adds some company type names

* Fixes typo

* Add en-ZA locale tests

* Update changelog

* Add another test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@bradleymarques bradleymarques

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradleymarques @vbrazo