Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default rake task #1207

Merged
merged 2 commits into from
May 15, 2018
Merged

use default rake task #1207

merged 2 commits into from
May 15, 2018

Conversation

stephengroat
Copy link
Contributor

@stephengroat
Copy link
Contributor Author

should be g2g, fixed a rubocop error with rubocop --auto-correct

@vbrazo vbrazo merged commit cc15d17 into faker-ruby:master May 15, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Rubocop = ❤️

Thanks man. See you soon.

@stephengroat stephengroat deleted the patch-1 branch May 15, 2018 17:47
@stephengroat
Copy link
Contributor Author

confirmed that rubocop is now running on master in travis

https://travis-ci.org/stympy/faker/jobs/379332356#L525

@vbrazo
Copy link
Member

vbrazo commented May 15, 2018

🥇

@vbrazo vbrazo self-requested a review July 19, 2018 01:38
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* use default rake task

* fix rubocop error with rubocop --auto-correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants