Missing i18n jobs fix #1142
Merged
Missing i18n jobs fix #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
May 12, 2018
lib/faker/job.rb
Outdated
| def title | ||
| parse('job.title') | ||
| end | ||
|
|
||
| def field; fetch('job.field'); end | ||
| def key_skill; fetch('job.key_skills'); end |
There was a problem hiding this comment.
Thanks for changing the code style. It was looking terrible 👍
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* update rake * add failing test for locale without translations * add fetch for position fixing faker-ruby#1139 * reformat class to make consistant with other Faker classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes issue #1139 which seems to occur when the locale used does not contain translations for the position.
There is a test that fails with the same error as reported in #1139. This had to be put in a new file to isolate it from messing with the i18n of other tests.
The other patches fix the issue and standardize whitespace in jobs.