Add meaningful error message when country code not found (#916)

faker-ruby · May 23, 2017 · f5617db · f5617db
1 parent f69e09c
commit f5617db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/faker/bank.rb b/lib/faker/bank.rb
@@ -13,6 +13,7 @@ def swift_bic
 
       def iban(bank_country_code="GB")
         details = iban_details.find { |country| country["bank_country_code"] == bank_country_code.upcase }
+        raise ArgumentError, "Could not find iban details for #{bank_country_code}" unless details
         bcc = details["bank_country_code"] + 2.times.map{ rand(10) }.join
         ilc = (0...details["iban_letter_code"].to_i).map{ (65 + rand(26)).chr }.join
         ib  = details["iban_digits"].to_i.times.map{ rand(10) }.join

diff --git a/test/test_faker_bank.rb b/test/test_faker_bank.rb
@@ -40,11 +40,10 @@ def test_iban_ro; assert @tester.iban("ro").match(/[A-Z]{4}[A-Z0-9]{16}/); end
   def test_iban_es; assert @tester.iban("es").match(/\d{20}/); end
   def test_iban_se; assert @tester.iban("se").match(/\d{20}/); end
   def test_iban_sk; assert @tester.iban("sk").match(/\d{24}/); end
-end
-
-
-
-
-
-
 
+  def test_iban_invalid
+    assert_raise ArgumentError.new("Could not find iban details for bad") do
+       @tester.iban("bad")
+    end
+  end
+end