Use concat instead of << to merge two arrays together.

This way we won't create nested arrays, plus it's faster.
faker-ruby · Nov 3, 2022 · b2787e8 · b2787e8
1 parent c4f3eaf
commit b2787e8
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/faker/sports/sport.rb b/lib/faker/sports/sport.rb
@@ -22,9 +22,15 @@ class << self
       #
       # @faker.version next
       def sport(include_ancient: false, include_unusual: false)
-        sports = fetch_all('sport.summer_olympics') + fetch_all('sport.winter_olympics') + fetch_all('sport.summer_paralympics') + fetch_all('sport.winter_paralympics')
-        sports << fetch_all('sport.ancient_olympics') if include_ancient
-        sports << fetch_all('sport.unusual') if include_unusual
+        sports = []
+        sports.concat(
+          fetch_all('sport.summer_olympics'),
+          fetch_all('sport.summer_paralympics'),
+          fetch_all('sport.winter_olympics'),
+          fetch_all('sport.winter_paralympics')
+        )
+        sports.concat(fetch_all('sport.ancient_olympics')) if include_ancient
+        sports.concat(fetch_all('sport.unusual')) if include_unusual
         sample(sports)
       end