Allow list to accept filter and match on class name #39
Conversation
| @@ -1 +1 @@ | |||
| 2.4.0 | |||
| 2.5.3 | |||
| expect(output.string).to match(/Faker/) | ||
| expect(output.string.lines.size).to be_positive | ||
| end | ||
|
|
||
| context 'when passing a filter option' do | ||
| let(:options) { super().merge(filter: filter) } |
There was a problem hiding this comment.
Whoah, I didn't know you could call super on a let object. Nice! 🎖 😃
| context 'when single `list` command' do | ||
| it 'executes successfully' do | ||
| command.execute(output: output) |
There was a problem hiding this comment.
I see you're warming up to the "mystery guest mitigation" style 😁
There was a problem hiding this comment.
I am! Maybe we should talk about standardizing on a spec style across the repo. If you want to standardize on the mystery guest mitigation style, we can remove the ‘let’s and have code that’s duplicated, but easier to reason about.
There was a problem hiding this comment.
I'm definitely open to that. I wonder if we can configure rubocop-rspec to enforce those rules. 🤔 But I really don't have any strong feelings on this one. 🙁
|
|
||
| private | ||
|
|
||
| def render(result, output) |
There was a problem hiding this comment.
Nice specialisation here. Eventually, I think we might define the Command#render superclass to have this shape since we have the same on the search command. But I think this is great for now as we might add some new commands (don't know which ones yet) and they might have a different shape
There was a problem hiding this comment.
That’s true, good call. I’ll keep that in mind moving forward!
| @@ -20,6 +20,44 @@ | |||
| expect(sample_result_value).to be_a(Array) | |||
| expect(sample_result_value).not_to be_empty | |||
| end | |||
|
|
|||
| context 'when passing a filter' do | |||
Co-Authored-By: Kabiru Mwenja <makabby@gmail.com>
Co-Authored-By: Kabiru Mwenja <makabby@gmail.com>
This PR addresses the list features requested in #20
New features:
listaccepts a filter, which can be a full class name or partial (case-sensitive) match. If there is no match, we return a 'not found' messageCloses #20