Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let faker list accept arguments #20

Closed
akabiru opened this issue Jan 18, 2019 · 9 comments · Fixed by #39
Closed

Let faker list accept arguments #20

akabiru opened this issue Jan 18, 2019 · 9 comments · Fixed by #39

Comments

@akabiru
Copy link
Owner

akabiru commented Jan 18, 2019

Description

At the moment running faker list will list out all Faker constants and the methods they respond to. This is cool and all but what if I just want to list Faker::Internet?

I should be able to run sth like faker list internet and this should list out the Faker::Internet class

The command should also support the verbose option and any other sensible options e.g. data type.

Screenshot 📷

screenshot 2019-01-18 at 10 50 08

@akabiru
Copy link
Owner Author

akabiru commented Mar 12, 2019

Moved to faker-ruby/faker#1569

@akabiru akabiru closed this as completed Mar 12, 2019
@vbrazo vbrazo reopened this Jul 6, 2019
@bpleslie
Copy link
Contributor

@akabiru thoughts on closing this in favor of the search changes in #38 ?

@akabiru
Copy link
Owner Author

akabiru commented Jul 26, 2019

@bpleslie I think this is a separate piece of work. It's an enhancement on the faker list method.

@akabiru
Copy link
Owner Author

akabiru commented Jul 26, 2019

@akabiru thoughts on closing this in favor of the search changes in #38 ?

Aaah, I see your point! From #38 you can run a faker search Faker::Beer and it'll achieve the functionality here.

For semantics, WDYT about adding the same functionality to the faker list command. i.e. faker list Faker::Beer 🤔

@bpleslie
Copy link
Contributor

bpleslie commented Jul 26, 2019

@akabiru I could see it added, but only if faker list Faker::Beer and faker list Beer match. In my opinion, we wouldn't need to support partial matches or lowercase queries for list. Thoughts?

@akabiru
Copy link
Owner Author

akabiru commented Jul 29, 2019

@akabiru I could see it added, but only if faker list Faker::Beer and faker list Beer match. In my opinion, we wouldn't need to support partial matches or lowercase queries for list. Thoughts?

I agree, there would be no need to support partial matches. The user case I have in mind:

1.) User calls faker list
2.) User just wants to list out one of the classes, so they can call faker list Beer or faker list Faker::Beer

I'm very open to re-evaluating if this feature is useful. WDYT?

@bpleslie
Copy link
Contributor

@akabiru I think this feature makes sense. I'm working on the code now 👍

@akabiru
Copy link
Owner Author

akabiru commented Jul 30, 2019

@akabiru I think this feature makes sense. I'm working on the code now 👍

Much appreciated. 🙇

@bpleslie
Copy link
Contributor

bpleslie commented Aug 6, 2019

@akabiru you can probably un-pin this issue 😄

@vbrazo vbrazo unpinned this issue Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants