Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Faker Deprecation Warnings; The CLI handles that - II #33

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Skip Faker Deprecation Warnings; The CLI handles that - II #33

merged 1 commit into from
Jul 14, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Jul 14, 2019 •
edited
Loading

Description

Since Faker::Bot::Base no longer runs "natively" in the Faker gem context, the fix we previously had to skip deprecation warnings at CLI runtime no longer works. 😭

However, since the bot operates outside of faker, we can disable the deprecation warnings via class_evaling into Faker::Base at runtime. 🙂

Background #19

@akabiru
fix: Disable default Faker deprecation warnings
72de2f1 
* The Bot renderer will mark methods pending deprecation
@akabiru akabiru requested a review from vbrazo July 14, 2019 04:31
vbrazo
vbrazo approved these changes Jul 14, 2019
View reviewed changes
Copy link
Collaborator

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo added the bug label Jul 14, 2019
@vbrazo vbrazo merged commit c80a2e0 into akabiru:master Jul 14, 2019
@akabiru akabiru deleted the fix/deprecation-warnings branch July 15, 2019 07:35
@akabiru akabiru added this to the 0.5.0 Release milestone Jul 31, 2019
@akabiru akabiru mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@akabiru akabiru

Labels
bug
Projects
None yet
Milestone
0.5.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@akabiru @vbrazo