Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Gem::Deprecate Warnings; The CLI handles that #19

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Jan 18, 2019

Description

When running a fakerbot command in verbose mode e.g. fakerbot list -v fakerbot actually invokes fakers methods; even ones with deprecation warnings.

When this happens faker will by default print the deprecation warnings. We don't really want that as the CLI is already showing deprecation warnings as handled in #10
Sample

screenshot 2019-01-18 at 10 35 16

Screenshots

fakerbot list -v

screenshot 2019-01-18 at 10 30 11

screenshot 2019-01-18 at 10 30 16

@coveralls
Copy link

Pull Request Test Coverage Report for Build 81

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.349%

Totals Coverage Status
Change from base Build 79: 0.0%
Covered Lines: 164
Relevant Lines: 172

💛 - Coveralls

@akabiru akabiru merged commit be432f8 into master Jan 18, 2019
@akabiru akabiru deleted the chore/silence-default-deprecation-warnings branch January 18, 2019 07:43
@akabiru akabiru added the bug label Jul 31, 2019
@akabiru akabiru self-assigned this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants