-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move some random methods to helpers #892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
labels
Apr 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 99.41% 99.41% -0.01%
==========================================
Files 1959 1959
Lines 210917 210980 +63
Branches 907 908 +1
==========================================
+ Hits 209687 209749 +62
- Misses 1172 1173 +1
Partials 58 58
|
Shinigami92
commented
Apr 30, 2022
Shinigami92
commented
Apr 30, 2022
ST-DDT
requested changes
May 1, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
approved these changes
May 1, 2022
ejcheng
approved these changes
May 1, 2022
xDivisionByZerox
added
the
m: helpers
Something is referring to the helpers module
label
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: helpers
Something is referring to the helpers module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we discussed stuff in #874 (comment) I move these into helpers