Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move some random methods to helpers #892

Merged
merged 15 commits into from
May 1, 2022

Conversation

Shinigami92
Copy link
Member

After we discussed stuff in #874 (comment) I move these into helpers

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 30, 2022
@Shinigami92 Shinigami92 added this to the v6.3 - Next Minor milestone Apr 30, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 30, 2022 09:18
@Shinigami92 Shinigami92 self-assigned this Apr 30, 2022
@Shinigami92 Shinigami92 marked this pull request as draft April 30, 2022 09:18
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #892 (ce6df4f) into main (af5606a) will decrease coverage by 0.00%.
The diff coverage is 97.37%.

❗ Current head ce6df4f differs from pull request most recent head 2e2bf13. Consider uploading reports for the commit 2e2bf13 to get more accurate results

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   99.41%   99.41%   -0.01%     
==========================================
  Files        1959     1959              
  Lines      210917   210980      +63     
  Branches      907      908       +1     
==========================================
+ Hits       209687   209749      +62     
- Misses       1172     1173       +1     
  Partials       58       58              
Impacted Files Coverage Δ
src/image_providers/lorempixel.ts 92.01% <0.00%> (ø)
src/finance.ts 99.31% <93.75%> (ø)
src/helpers.ts 98.88% <94.66%> (-0.44%) ⬇️
src/address.ts 99.79% <100.00%> (+<0.01%) ⬆️
src/animal.ts 100.00% <100.00%> (ø)
src/commerce.ts 100.00% <100.00%> (ø)
src/company.ts 100.00% <100.00%> (ø)
src/database.ts 100.00% <100.00%> (ø)
src/datatype.ts 100.00% <100.00%> (ø)
src/date.ts 100.00% <100.00%> (ø)
... and 14 more

@Shinigami92 Shinigami92 marked this pull request as ready for review April 30, 2022 09:50
@Shinigami92 Shinigami92 marked this pull request as draft April 30, 2022 09:53
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as ready for review April 30, 2022 09:58
@Shinigami92 Shinigami92 requested review from ST-DDT and a team May 1, 2022 09:58
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@Shinigami92 Shinigami92 requested review from ST-DDT and a team May 1, 2022 12:15
@ST-DDT ST-DDT requested a review from a team May 1, 2022 12:46
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 1, 2022 13:18
@Shinigami92 Shinigami92 merged commit c093e4c into main May 1, 2022
@prisis prisis deleted the move-some-random-to-helpers branch May 3, 2022 07:15
@xDivisionByZerox xDivisionByZerox added the m: helpers Something is referring to the helpers module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants