build: add node v18 support #847
Merged
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
c: chore
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 1958 1958
Lines 210679 210679
Branches 908 907 -1
==========================================
- Hits 209934 209931 -3
- Misses 726 729 +3
Partials 19 19
|
Shinigami92
commented
Apr 20, 2022
Shinigami92
added
the
s: on hold
|
According to this table https://kangax.github.io/compat-table/es2016plus/#node14_0 I think we can also switch to target 2020 🥳 |
Shinigami92
removed
the
s: on hold
Shinigami92
modified the milestones:
v6 - Non-Breaking Changes,
v7 - Current Major,
v7.0 - Next Minor
ST-DDT
approved these changes
May 3, 2022
|
This probably need admin powers to be merged. |
pkuczynski
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for node v12 completely (maybe we can do this in a separate PR if we need to long for other v6.x stuff)see build!: remove node v12 support #850