Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve variable naming of helpers module #3316

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 3, 2024

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Dec 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 3, 2024
@ST-DDT ST-DDT self-assigned this Dec 3, 2024
@ST-DDT ST-DDT requested a review from a team as a code owner December 3, 2024 10:35
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team December 3, 2024 10:36
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 54058ef
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/675d665f842a6100082cb7c2
😎 Deploy Preview https://deploy-preview-3316.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT removed the request for review from xDivisionByZerox December 3, 2024 10:36
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (ff6dda9) to head (54058ef).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3316   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217012   217012           
  Branches      939      937    -2     
=======================================
  Hits       216961   216961           
  Misses         51       51           
Files with missing lines Coverage Δ
src/modules/helpers/index.ts 96.71% <100.00%> (ø)

@ST-DDT ST-DDT merged commit ca52d31 into next Dec 14, 2024
23 checks passed
@ST-DDT ST-DDT deleted the coding-style/helpers branch December 14, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants