Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add books on pt_br #3218

Merged

Conversation

guilherme-codes
Copy link
Contributor

It Adds the book locales to pt_BR.

@guilherme-codes guilherme-codes requested a review from a team as a code owner October 24, 2024 01:54
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6fb45ec
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671a8108fd94cb0008143f74
😎 Deploy Preview https://deploy-preview-3218.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guilherme-codes guilherme-codes changed the title feat (locale): add books on pt_br feat: (locale) add books on pt_br Oct 24, 2024
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort all entries alphabetically

Copy link
Contributor

GitHub Actions has found some problems running the preflight checks.

Please make sure to:

  • run pnpm run preflight locally
  • fix all issues until the command completes without errors
  • commit and push the changes

@matthewmayer matthewmayer changed the title feat: (locale) add books on pt_br feat(locale): add books on pt_br Oct 24, 2024
@matthewmayer
Copy link
Contributor

Also

Error: Duplicated values are [Obra poética]

If you can run the preflight command locally that will do the sorting for you and spot minor errors like this.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: book Something is referring to the animal module labels Oct 24, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (e3858f2) to head (6fb45ec).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3218      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2797     2804       +7     
  Lines      216762   216974     +212     
  Branches      579      958     +379     
==========================================
+ Hits       216686   216886     +200     
- Misses         76       88      +12     
Files with missing lines Coverage Δ
src/locales/pt_BR/book/author.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/format.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/genre.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/index.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/publisher.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/series.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/book/title.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from matthewmayer and a team October 24, 2024 18:18
@ST-DDT ST-DDT merged commit af1dbcd into faker-js:next Oct 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: book Something is referring to the animal module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants