Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): permanently disable no-object-as-default-parameter #3203

Merged
merged 7 commits into from
Nov 3, 2024
Merged

infra(unicorn): permanently disable no-object-as-default-parameter #3203

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
582b017
infra(unicorn): permanently disable no-object-as-default-parameter
ST-DDT Oct 20, 2024
9797fe2
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Oct 22, 2024
49ca9d9
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Oct 23, 2024
2725f04
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Oct 25, 2024
2474aeb
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Oct 26, 2024
293cbd1
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Nov 2, 2024
fa8c91f
Merge branch 'next' into infra/unicorn/no-object-as-default-parameter
ST-DDT Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ const config: ReturnType<typeof tseslint.config> = tseslint.config(
'unicorn/import-style': 'off', // subjective & doesn't do anything for us
'unicorn/no-array-callback-reference': 'off', // reduces readability
'unicorn/no-nested-ternary': 'off', // incompatible with prettier
'unicorn/no-object-as-default-parameter': 'off', // https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2199
'unicorn/no-null': 'off', // incompatible with TypeScript
'unicorn/no-zero-fractions': 'off', // deactivated to raise awareness of floating operations
'unicorn/number-literal-case': 'off', // incompatible with prettier
Expand All @@ -157,7 +158,6 @@ const config: ReturnType<typeof tseslint.config> = tseslint.config(
// TODO @Shinigami92 2023-09-23: The following rules currently conflict with our code.
// Each rule should be checked whether it should be enabled/configured and the problems fixed, or stay disabled permanently.
'unicorn/consistent-function-scoping': 'off',
'unicorn/no-object-as-default-parameter': 'off',
'unicorn/prefer-export-from': 'off',
'unicorn/prefer-string-slice': 'off',
'unicorn/prevent-abbreviations': 'off',
Expand Down