-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(location): allow postcode_by_state to take an array of patterns #3170
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3170 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2798 2798
Lines 227808 227808
Branches 580 955 +375
==========================================
- Hits 227748 227733 -15
- Misses 60 75 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. Would we change the definition property type to only string[]
in v10?
I'd prefer using actual code instead of string patterns for v10. |
ref #3169
This change will make it easier to handle ZIP codes where there are "holes" in the ranges.
For example Hawaii could use two ranges like this to exclude 96799 (American Samoa)
Since
faker.helpers.fake
accepts an array, just need to change the type. Will change the actual definitions in a followup PR.