Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update unique values guide with new library #3166

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

dPaskhin
Copy link
Contributor

@dPaskhin dPaskhin commented Oct 9, 2024

No description provided.

@dPaskhin dPaskhin requested a review from a team as a code owner October 9, 2024 21:33
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 7b79cea
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670851985ade4a00086376a8
😎 Deploy Preview https://deploy-preview-3166.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 9, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 9, 2024
@ST-DDT ST-DDT linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (d516392) to head (7b79cea).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3166   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2797     2797           
  Lines      227777   227777           
  Branches      581      582    +1     
=======================================
+ Hits       227702   227715   +13     
+ Misses         75       62   -13     

see 2 files with indirect coverage changes

@Shinigami92
Copy link
Member

Team Decision:

We discussed the inclusion of third-party extension code in our documentation and concluded that maintaining it in multiple locations may not be efficient. By removing it from our documentation, you have the flexibility to manage your package independently, without you having to make further updates on our end.
That being said, we're more than happy to include links to other packages, like yours.

This also applies to enforce-unique.

Please remove everything from line 30 onward.

docs/guide/unique.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team October 10, 2024 22:14
@ST-DDT ST-DDT requested a review from a team October 10, 2024 22:21
@ST-DDT ST-DDT merged commit d43d68d into faker-js:next Oct 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate helpers.unique for removal
5 participants