Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: remove package.json warnings #3097

Closed
wants to merge 3 commits into from
Closed

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Sep 7, 2024

closes #3078

I obviously choose not to remove default but import, so we fallback to simply .js files in any other case, and do not change the runtime behavior.
If we would remove default instead of import, I highly assume it would either fail for e.g. browser, or any other possible kind, instead of at least trying to function.
If then for any other kind either something works or does not work, contributors can then still report an issue.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Sep 7, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Sep 7, 2024
@Shinigami92 Shinigami92 self-assigned this Sep 7, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 7, 2024 16:15
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9d41c3f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66dfe1c7c8b38d000862c8e5
😎 Deploy Preview https://deploy-preview-3097.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (18ab2c7) to head (9d41c3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3097   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2776     2776           
  Lines      226260   226260           
  Branches      945      943    -2     
=======================================
+ Hits       226183   226201   +18     
+ Misses         77       59   -18     

see 1 file with indirect coverage changes

@Shinigami92 Shinigami92 mentioned this pull request Sep 8, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Sep 8, 2024

Please edit the description for future reference why you opted to remove the import statement rather the default statement as suggested by the warning message.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 12, 2024

I would vote to close this in favor of #3093

@ST-DDT ST-DDT deleted the 3078-fix-pkg-exports branch October 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning in package.json during build
3 participants