-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add npm to social links #2971
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2971 +/- ##
========================================
Coverage 99.95% 99.96%
========================================
Files 2989 2989
Lines 216081 216081
Branches 596 951 +355
========================================
+ Hits 215986 216002 +16
+ Misses 95 79 -16 |
Not sure which social links we need. |
You think a user might get overwhelmed by the amount of icons if we would put in all applicable icon? |
I think that is a concern especially for less well known ones like OpenCollective. |
I think 6 is tolerable. I would try to avoid 7 or more. |
Description
Add a NPM social icon to the navigation of our documentation page.