Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(image)!: remove v8 deprecated providers #2634

Merged
merged 8 commits into from
Feb 14, 2024
Merged

refactor(image)!: remove v8 deprecated providers #2634

merged 8 commits into from
Feb 14, 2024

Conversation

Shinigami92
Copy link
Member

extracted from #2608

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: image Something is referring to the image module labels Jan 29, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Jan 29, 2024
@Shinigami92 Shinigami92 self-assigned this Jan 29, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 29, 2024 19:20
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c96176b) 99.54% compared to head (44d7791) 99.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2634      +/-   ##
==========================================
+ Coverage   99.54%   99.55%   +0.01%     
==========================================
  Files        2820     2817       -3     
  Lines      251751   251199     -552     
  Branches     1161     1122      -39     
==========================================
- Hits       250603   250080     -523     
  Misses       1119     1119              
+ Partials       29        0      -29
Files Coverage Δ
src/modules/image/index.ts 100.00% <ø> (ø)

... and 31 files with indirect coverage changes

@Shinigami92 Shinigami92 force-pushed the remove-deprecated-image-providers branch from a713701 to 5ebfbb8 Compare January 29, 2024 19:24
@Shinigami92 Shinigami92 requested a review from a team January 29, 2024 19:24
@xDivisionByZerox xDivisionByZerox requested review from a team January 29, 2024 19:38
@Shinigami92 Shinigami92 requested a review from ST-DDT February 9, 2024 18:22
@Shinigami92 Shinigami92 requested a review from ST-DDT February 9, 2024 18:54
ST-DDT
ST-DDT previously approved these changes Feb 9, 2024
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 9, 2024 18:59
matthewmayer
matthewmayer requested changes Feb 10, 2024
View reviewed changes
docs/guide/upgrading_v9/2634.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Feb 10, 2024
View reviewed changes
@ST-DDT ST-DDT requested review from a team February 10, 2024 11:12
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Feb 10, 2024
matthewmayer
matthewmayer requested changes Feb 10, 2024
View reviewed changes
docs/guide/upgrading_v9/2634.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team February 11, 2024 18:46
@Shinigami92 Shinigami92 added deprecation A deprecation was made in the PR and removed deprecation A deprecation was made in the PR labels Feb 11, 2024
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 14, 2024 19:32
@Shinigami92 Shinigami92 merged commit 44d698e into next Feb 14, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-image-providers branch February 25, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox