Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): migrate to vitest #235

Merged
merged 38 commits into from
Jan 21, 2022
Merged

chore(test): migrate to vitest #235

merged 38 commits into from
Jan 21, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior c: test labels Jan 19, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: c528cb5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eafae3b3cb7300078d3258

😎 Browse the preview: https://deploy-preview-235--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 mentioned this pull request Jan 19, 2022
Closed
This was referenced Jan 20, 2022
Closed
Merged
@Shinigami92 Shinigami92 mentioned this pull request Jan 20, 2022
Merged
@Shinigami92 Shinigami92 marked this pull request as ready for review January 20, 2022 18:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 20, 2022 18:25
@Shinigami92
Copy link
Member Author

/cc @antfu @patak-dev 😃

ejcheng
ejcheng previously approved these changes Jan 20, 2022
View reviewed changes
JessicaSachs
JessicaSachs previously approved these changes Jan 20, 2022
View reviewed changes
This was referenced Jan 21, 2022
Merged
Merged
ST-DDT
ST-DDT previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on windows

@Shinigami92 Shinigami92 merged commit 60c9002 into main Jan 21, 2022
@Shinigami92 Shinigami92 deleted the migrate-to-vitest branch January 21, 2022 21:29
@CalebBurton CalebBurton mentioned this pull request Jan 21, 2022
Merged
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
@Shinigami92 @pkuczynski
chore(test): migrate to vitest (faker-js#235)
53a1cf3
@ST-DDT ST-DDT mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaSachs JessicaSachs JessicaSachs approved these changes

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng left review comments

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

@griest024 griest024 Awaiting requested review from griest024

@clarkerican clarkerican Awaiting requested review from clarkerican

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
5 participants
@Shinigami92 @ST-DDT @prisis @JessicaSachs @ejcheng