Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): ro_MD #1936

Closed
wants to merge 10 commits into from
Closed

feat(locale): ro_MD #1936

wants to merge 10 commits into from

Conversation

botzill
Copy link

@botzill botzill commented Mar 15, 2023

Created new PR after rebase with upstream

@botzill botzill requested a review from a team March 15, 2023 12:21
@botzill botzill requested a review from a team as a code owner March 15, 2023 12:21
@botzill botzill mentioned this pull request Mar 15, 2023
Closed
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1936 (623e7a1) into next (e5442d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             next    #1936     +/-   ##
=========================================
  Coverage   99.63%   99.63%             
=========================================
  Files        2357     2394     +37     
  Lines      236815   238375   +1560     
  Branches     1225     1224      -1     
=========================================
+ Hits       235941   237504   +1563     
+ Misses        852      849      -3     
  Partials       22       22
Impacted Files Coverage Δ
src/locale/ro_MD.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/cell_phone/formats.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/month.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/internet/free_email.ts 100.00% <100.00%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Mar 15, 2023

Please run pnpm run preflight.

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Mar 23, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 23, 2023

Please update your PR.

@xDivisionByZerox xDivisionByZerox changed the title feat(locale): Add locale ro_MD feat(locale): ro_MD Apr 7, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Apr 12, 2023

Closing inactive PR.
Please leave a comment, when you fixed the issue.

@ST-DDT ST-DDT closed this Apr 12, 2023
@matthewmayer matthewmayer mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@botzill botzill

Labels
c: locale Permutes locale definitions needs rebase There is a merge conflict p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@botzill @ST-DDT