-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct types field #1878
fix: correct types field #1878
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1878 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2355 2355
Lines 236763 236763
Branches 1157 1155 -2
==========================================
- Hits 235922 235903 -19
- Misses 819 838 +19
Partials 22 22
|
I found this commit, that "reverted" your change: |
I don't remember everything 9 month ago, but see my comment #979 (review) At Vue Amsterdam 2023 I learned a bit more about |
Actually I think before, this might work too as you had the |
This reverts commit 956a15f.
fixing: https://publint.dev/@faker-js/faker@7.6.0
There is no
index.d.ts
Everything is packaged into the dist folder
This might only affect users using TS + an old npm version that doesn't know the
exports
field