-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(system): add valid 0 for cron #1787
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1787 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 2340 2340
Lines 242622 242622
Branches 1113 1113
=======================================
Hits 241786 241786
Misses 815 815
Partials 21 21 |
This PR targeted the wrong goal and was meant to fix the shuffled tests |
I'll provide a follow up PR which addresses this test reimplementation. |
After checking the source I noticed that the fix for the test was totally valid. The title should probably simply be adjusted to state |
While working on
it reports an failure for https://github.com/faker-js/faker/actions/runs/4025222101/jobs/6918173202#step:7:302
but
0
is a valid digit for cron