Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(locale): split es_MX names into female/male #1704

Merged
merged 2 commits into from
Jan 2, 2023
Merged

chore(locale): split es_MX names into female/male #1704

merged 2 commits into from
Jan 2, 2023

Conversation

matthewmayer
Copy link
Contributor

split from #1677
similar logic to #1692 but for es_MX

@matthewmayer matthewmayer requested a review from a team as a code owner January 1, 2023 10:28
@codecov
Copy link

codecov bot commented Jan 1, 2023 •
edited
Loading

Codecov Report

Merging #1704 (2342792) into next (f0e859b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1704   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2245     2247    +2     
  Lines      240396   240410   +14     
  Branches     1079     1079           
=======================================
+ Hits       239521   239535   +14     
  Misses        854      854           
  Partials       21       21
Impacted Files Coverage Δ
src/locales/es_MX/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/es_MX/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/es_MX/person/index.ts 100.00% <100.00%> (ø)
src/locales/es_MX/person/male_first_name.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 requested review from ejcheng and a team January 2, 2023 14:23
@ejcheng ejcheng added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: person Something is referring to the person module labels Jan 2, 2023
@ejcheng ejcheng added this to the v8.0 - Module Re-Shuffling milestone Jan 2, 2023
@Shinigami92 Shinigami92 changed the title chore(locale): split es_MX names into male/female chore(locale): split es_MX names into female/male Jan 2, 2023
@Shinigami92 Shinigami92 enabled auto-merge (squash) January 2, 2023 20:55
@Shinigami92 Shinigami92 disabled auto-merge January 2, 2023 20:55
@Shinigami92 Shinigami92 enabled auto-merge (squash) January 2, 2023 20:55
@Shinigami92 Shinigami92 merged commit b8c522e into faker-js:next Jan 2, 2023
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
@pladreyt
chore(locale): split es_MX names into female/male (faker-js#1704)
137eac6
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
@pladreyt
chore(locale): split es_MX names into female/male (faker-js#1704)
2e3e255
@matthewmayer matthewmayer mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejcheng ejcheng ejcheng approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng