Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: another experiment #1266

Closed
wants to merge 1 commit into from
Closed

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Aug 12, 2022

Alternative draft for #1250

This is another solution and would be what was initially planned as second step after #1254

@Shinigami92 Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Aug 12, 2022
@Shinigami92 Shinigami92 self-assigned this Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1266 (c66ddf2) into main (462ee5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1266   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2156     2162    +6     
  Lines      237025   237071   +46     
  Branches     1006     1016   +10     
=======================================
+ Hits       236126   236182   +56     
+ Misses        878      868   -10     
  Partials       21       21           
Impacted Files Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)
src/modules/git/branch.ts 100.00% <100.00%> (ø)
src/modules/git/commitEntry.ts 100.00% <100.00%> (ø)
src/modules/git/commitMessage.ts 100.00% <100.00%> (ø)
src/modules/git/commitSha.ts 100.00% <100.00%> (ø)
src/modules/git/hexChars.ts 100.00% <100.00%> (ø)
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/git/shortSha.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 84.39% <0.00%> (+2.64%) ⬆️

@Minozzzi
Copy link
Contributor

I liked this approach, in my opinion keeps the code separate and organized.

@Shinigami92
Copy link
Member Author

Closing these experiments for now

@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2023

@Shinigami92 Do you still need the branch? If not, please delete it.

Commit-ID: c66ddf2

@Shinigami92
Copy link
Member Author

Yes, please do not delete them right now so we have a copy and look into it if needed
I just wanted to clean the PR section as we would need to rewrite them anyway as they got to stale

@ST-DDT ST-DDT deleted the rewrite-modules-into-pieces branch October 9, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs do NOT merge yet Do not merge this PR into the target branch yet s: needs decision Needs team/maintainer decision
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants