-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert types field #1966
Merged
Merged
fix: revert types field #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 956a15f.
Shinigami92
changed the title
Revert "fix: correct types field (#1878)"
fix: revert types field
Mar 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1966 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2384 2384
Lines 238992 238992
Branches 1231 1227 -4
==========================================
- Hits 238127 238110 -17
- Misses 843 860 +17
Partials 22 22 |
I suppose it was working because #1878 (comment) was true. That the |
xDivisionByZerox
approved these changes
Mar 23, 2023
ST-DDT
approved these changes
Mar 23, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
c: infra
Changes to our infrastructure or project setup
p: 3-urgent
Fix and release ASAP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 956a15f.
This had broken the whole package!
@bluwy
"types": "index.d.ts"
is working hereDo you know anything about that? Why did publint reported this as invalid? Or even: what is going on here?