Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #1

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a7b9bb1
restore previous animint code before refactoring
faizan-khan-iit May 18, 2017
ce209c5
separate general functions in a different file
faizan-khan-iit May 18, 2017
49c7c78
separate creating a new environment to a specific animint helper file
faizan-khan-iit May 18, 2017
0f09a7c
move checking for errors in plot.list and plot.list to aniimint speci…
faizan-khan-iit May 18, 2017
2ef7e05
move merge_recurse to animintHelpers.R
faizan-khan-iit May 19, 2017
782582a
move plot checks before calling ggplot_build to animintHelpers.R
faizan-khan-iit May 19, 2017
fa4a8fe
move selector warnings to animint specific helpers
faizan-khan-iit May 19, 2017
0ad9474
move showSelected warning to animint specific helpers
faizan-khan-iit May 19, 2017
be0c9d4
set plot sizes in animint helpers
faizan-khan-iit May 19, 2017
941f345
move pt.to.lines() to general helpers
faizan-khan-iit May 19, 2017
e2f3923
adding showSelected for Legend moved to animint specific functions
faizan-khan-iit May 19, 2017
8768af2
move functions for background and grid info to animint helpers
faizan-khan-iit May 19, 2017
c9dc4e0
move getting unique axis labels to animint helpers. Also made correct…
faizan-khan-iit May 20, 2017
2f1f966
get plot title in animint helpers
faizan-khan-iit May 20, 2017
ce06d9a
move hjust2anchor to animint helpers
faizan-khan-iit May 20, 2017
87ef02b
move plot width and height to animint helpers
faizan-khan-iit May 20, 2017
1fc4154
move update axes option to animmint helpers
faizan-khan-iit May 20, 2017
ea17dce
move getting layer params to animint helpers
faizan-khan-iit May 20, 2017
7790dd2
move filtering of columns to animint helpers
faizan-khan-iit May 20, 2017
025ec70
move check for Non Identity Stat + showSelected to animint helpers
faizan-khan-iit May 20, 2017
b4ab179
move switch_axes for coord_flip to animint helpers
faizan-khan-iit May 20, 2017
f91ee88
forgot doc files for switch axes
faizan-khan-iit May 20, 2017
440fb84
move is.linetype() to animint helpers
faizan-khan-iit May 20, 2017
b6a32ef
move getLegend to animint helpers
faizan-khan-iit May 23, 2017
757bac4
move getCommonChunk, saveChunks, split.x, varied.chunk to animint hel…
faizan-khan-iit May 23, 2017
0198619
do not need makeDocs anymore
faizan-khan-iit May 25, 2017
cf722e7
add tests and testing framework
faizan-khan-iit May 27, 2017
9b02ba9
modify .gitignore for ANIMINT_TEST_FOO and pids.txt
faizan-khan-iit May 27, 2017
dc221ba
remove geom.count from meta. Note: something weird going on with knit…
faizan-khan-iit May 27, 2017
01e93cf
pass plots and layers separately in parsePlot and saveLayer
faizan-khan-iit May 28, 2017
4e2eda4
separate storeLayer from saveLayer. Note: fixed knit_print issue
faizan-khan-iit May 28, 2017
3296518
get layer names separately -> getLayerName
faizan-khan-iit May 28, 2017
a8e0a2d
forgot built data in get_grid
faizan-khan-iit May 29, 2017
af8f35a
remove gg2animint
faizan-khan-iit May 29, 2017
fcf0763
separate passing of plot info from meta
faizan-khan-iit May 30, 2017
aaa438d
rename plot.meta to plot.info in parsePlot
faizan-khan-iit May 30, 2017
b0a3e3e
we do not use meta.class anymore
faizan-khan-iit May 30, 2017
a58784a
Animation information is passed via AnimationInfo list
faizan-khan-iit Jun 8, 2017
c3af3a9
removeUniquePanelColumn to animintHelpers
faizan-khan-iit Jun 8, 2017
ec4d901
move compute_domains and related axes update functions to animintHelpers
faizan-khan-iit Jun 9, 2017
5c3be15
add data for the package
faizan-khan-iit Jun 10, 2017
179b742
update DESCRIPTION file
faizan-khan-iit Jun 13, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@
.RData
.Ruserdata
*.Rproj
.httr-oauth
*.httr-oauth
*animint-htmltest*
*intreg-selection*
*ANIMINT_TEST_FOO
*pids.txt
7 changes: 4 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
Package: animint2
Title: What the Package Does (one line, title case)
Version: 2.0.0.0000
Title: Interactive animations
Version: 2017.06.13
Authors@R: person("First", "Last", email = "first.last@example.com", role = c("aut", "cre"))
Description: What the package does (one paragraph).
Description: An interactive animation can be defined using a list of
ggplots with clickSelects and showSelected aesthetics.
Depends: R (>= 3.3.2)
License: What license is it under?
Encoding: UTF-8
Expand Down
5 changes: 1 addition & 4 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@
export(animint2dir)
export(animint2gist)
export(animintOutput)
export(geom_point_animint)
export(geom_tallrect)
export(geom_widerect)
export(getLegendList)
export(gg2animint)
export(is.rgb)
export(knit_print.animint)
export(makeDocs)
export(knit_print.animint2)
export(make_bar)
export(make_tallrect)
export(make_tallrect_or_widerect)
Expand Down
Loading