Do not force LANG env var on login #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing since it got fixed in the Zig rewrite. To compensate, I'll tag your account when 1.0.0 is gong to be released for making the original patch. |
|
@AnErrupTion don't worry about it, I just changed a single line :) |
I'd feel bad not to credit you even if it's just a single line change! You have no idea how many of those are actually useful 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #278
Is there any reason we have to set the LANG env var?
At least on arch systems this causes the custom LC_* configs form /etc/locale.conf to not be applied (/etc/profile.d/locale.sh
if [ -z "$LANG" ]; then)