Use tb_poll_event instead of tb_peek_event #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobrs
changed the title
|
This is definitely a step in the right direction, however it breaks animations: we should decide which method to use depending on the current configuration. If the animations are enabled, we should peek events. If not, then we can poll. If you can make these changes I will merge this asap :) |
nullgemm
added
ok
|
I added a call to |
draw_box and position_input are called because they need to be called before *input_handles[active_input] for the cursor to be positioned correctly.
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces CPU usage noticeably on my system, from 14% to nearly 0%. There is an issue where the cursor doesn't get positioned correctly on startup, this is because the cursor position is set in
input_handles[active_input]on line 144 (which calls tb_set_cursor), beforeposition_inputshas been called. It is not enough to just callposition_inputsbefore line 144, becauseposition_inputsitself requires thatdraw_boxhas been called,There are other issues with this approach as well, if I can't find a solution for them it might be easier to just increase the default min_refresh_delta.