Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all default features. Making them opt-in #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faern
Copy link
Owner

@faern faern commented Feb 2, 2025

The reason for this is outlined in the comment in Cargo.toml in the PR content itself.

Before this can be merged, I need to add fancy documentation helper tags that makes everything show up neatly on docs.rs.

We can also consider dropping the async feature and always support at least async receiving. It will compile in some unnecessary complexity, but maybe it's negligible compared to the complexity of keeping some of the code conditionally compiled etc. We should probably not remove the std feature, since it's needed to allow making the crate no_std. However, it can be discussed whether it's better renamed to blocking or similar. Since what it allows is blocking receive operations, which happens to have the side effect of requiring the standard library.

@faern faern added this to the Release 1.0 milestone Feb 2, 2025
@faern faern force-pushed the no-default-features branch from 0c5be96 to a056ca5 Compare February 2, 2025 21:37
@madsmtm madsmtm mentioned this pull request Feb 4, 2025
@faern faern force-pushed the no-default-features branch from a056ca5 to a4098c4 Compare February 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant