Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow #21

Closed
samoylovfp opened this issue May 26, 2021 · 9 comments · Fixed by #33
Closed

Overflow #21

samoylovfp opened this issue May 26, 2021 · 9 comments · Fixed by #33

Comments

@samoylovfp
Copy link

After using this for awhile I noticed this

image

I was able to buy sword and shield of 175 level which is cool, but fights not happen pretty slowly

This was referenced May 26, 2021
@facundoolano
Copy link
Owner

I'm exploring some fixes for this here in case someone wants to try it up and see how it plays.

@vito-laurenza-zocdoc
Copy link

I pulled the latest but I can still reproduce the overflow. (I think I did anyway; I just re-ran cargo install --git https://github.com/facundoolano/rpg-cli --branch main)

$ rpg

    hero[167]@home
    hp:[xxxxxxxxxx] -2035867958/-2035867958
    xp:[x---------] 1185/64743
    att:-1884151041   def:4340737   spd:1345772
    equip:{sword[75],shield[75]}
    item:{}
    2234944g

@facundoolano
Copy link
Owner

@vito-laurenza-zocdoc I think that's a known issue with cargo install.

Can you try again passing the --force flag to cargo install?

@vito-laurenza-zocdoc
Copy link

I tried with --force. I see a new timestamp on the file in ~/.cargo/bin/rpg-cli. I can still reproduce the overflow.

$ rpg

    hero[165]@home
    hp:[xxxxxxxxxx] -1899234251/-1899234251
    xp:[x---------] 6142/63583
    att:-1854956476   def:4340737   spd:1113458
    equip:{sword[75],shield[75]}
    item:{}
    2078088g

@facundoolano
Copy link
Owner

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

@vito-laurenza-zocdoc
Copy link

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

I meant to mention that I did --reset before grinding levels again.

@vito-laurenza-zocdoc
Copy link

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

I meant to mention that I did --reset before grinding levels again.

I think I had $RPG_CLI pointing to a different binary. I'm trying again.

@vito-laurenza-zocdoc
Copy link

I think that was my issue. Leveling is much slower now and I'm already over lvl 75 and haven't hit the issue.

@facundoolano
Copy link
Owner

Great, thanks for taking the time to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants