-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
To avoid having to install using a bash script, we can specify a version of prompt_toolkit and provide the github branch tarball for 2.0 as a dependency link. This means when installing with pip install sml-sync --process-dependency-links, pip will install prompt toolkit from the github repo. This means we can close the bitbucket repo.
- Loading branch information
There are no files selected for viewing
5 comments
on commit 17976a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be an alternative? I think it only works for pip 10
onwards, though.
Never mind -- I still don't think you can specify the URL-like syntax in install_requires
(if the last comment on this is anything to go by).
I think your changes look good. We should test it with different versions of pip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll try it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janfreyberg: Can you set your committer name and email and amend this commit?
From: "Jan (temporary)" <jantemporary@asi022-mbp.local>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srstevenson Just tried that but amending the commit doesn't seem to be changing the email in the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use e.g. git commit --amend --no-edit --author="Author Name <email@address.com>"
.
For reference, Python does string concatenation without a
+
:Instead of writing
['a' + 'b']
, it's more idiomatic to write['a' 'b']
.