Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in DropdownMenu dismissal #751

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Fix regression in DropdownMenu dismissal #751

merged 2 commits into from
Nov 14, 2021

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Oct 24, 2021 •
edited
Loading

This PR restores two properties of DropdownMenu:

  • Menu will dismiss when user clicks outside the menu.
  • Menu will dismiss if user presses escape key.

Resolves one of the issues documented in #750

@tcbegley tcbegley merged commit 22ff6b0 into main Nov 14, 2021
@tcbegley tcbegley deleted the dropdownmenu-dismissal branch November 14, 2021 20:50
This was referenced Nov 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tcbegley