Fix react-redux 6.0.0 new way of passing context #113
Conversation
|
assessing multiple PRs regarding the same fix, checking with authors of those prs if there's anything they want to review on this one |
| const mapState = state => ({ | ||
| routesMap: selectLocationState(state).routesMap | ||
| }) | ||
| const connector: Connector<OwnProps, Props> = connect(mapState) |
There was a problem hiding this comment.
Shouldn't dispatch be mapped to props here?
There was a problem hiding this comment.
Hum, what do you have in mind?
Do you see a case dispatch is needed?
There was a problem hiding this comment.
It's already used and in a Redux context, dispatching action is needed, I guess. :)
There was a problem hiding this comment.
dispatch was not present before, is this necessary?
I wonder
There was a problem hiding this comment.
There was a problem hiding this comment.
And this is officially supported, ok. 👍
src/NavLink.js
Outdated
| @@ -37,39 +36,31 @@ type OwnProps = { | |||
|
|
|||
| type Props = { | |||
| dispatch: Function, | |||
There was a problem hiding this comment.
Line 39 could be removed, I think.
|
If still relevant @GuillaumeCisco @cdoublev Please merge with master and resolve conflicts, then ill merge it if the community (you guys) say yes |
|
Ill merge this if we can resolve the conflicts. Otherwise give me like 4 hours and ill do so on my machine. Again I’m really sorry i got PR's mixed up |
|
Sounds more efficient that I let you both handle that from your own PR/repository. I should probably have closed my PR @ScriptedAlchemy: also my fault. |
|
Thanks @cdoublev and @ScriptedAlchemy. |
|
Sure thing I'll update your pr tomorrow and merge. Tomorrow is my last day before family vacation to the mountains. No idea what wireless service is there. So I'll make sure this is merge tomorrow. Merry Christmas or happy holidays!!! |
GuillaumeCisco
force-pushed
the
fix-react-redux-6
branch
from
5966918
to
fb38fc1
Compare
|
Just got some time to rebase it :) |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Checking in here, we all good? |
|
Yes, thank you both. I just updated it with react-redux: links are working correctly. 👍 |
|
Thanks guys. I really appreciatate it! |
Fix #101