Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Changelog + codecov #191

Merged
merged 1 commit into from
Jan 24, 2022
Merged

[minor] Changelog + codecov #191

merged 1 commit into from
Jan 24, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Follow up from #189, I forgot to update the changelog, and updating codecov so that /experimental is not counted (there are tests, but need triton v2 and build from source for now

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #191 (cbf3a67) into main (02e5abc) will increase coverage by 12.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #191       +/-   ##
===========================================
+ Coverage   79.49%   91.97%   +12.48%     
===========================================
  Files          64       57        -7     
  Lines        3389     2929      -460     
===========================================
  Hits         2694     2694               
+ Misses        695      235      -460     
Flag Coverage Δ
Python 91.97% <ø> (+12.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
experimental/ragged_inference/seq_kv_cache.py
...al/ragged_inference/triton_v2_ragged_qk_dotprod.py
...mental/ragged_inference/garbage_pad_ragged_acts.py
experimental/ragged_inference/test_utils.py
experimental/setup.py
experimental/ragged_inference/triton_v2_matmul.py
...erimental/ragged_inference/triton_v2_qk_dotprod.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e5abc...cbf3a67. Read the comment docs.

@blefaudeux blefaudeux merged commit fd160d5 into main Jan 24, 2022
@blefaudeux blefaudeux deleted the fix_codecov branch January 24, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants