Skip to content

Commit

Permalink
Fix VRSFileReadTest crasher
Browse files Browse the repository at this point in the history
Summary:
Cache blocks in the async queue are referenced by pointer, so copying them when purging isn't safe.
This explains long standing crashes with VRSFileReadTest.

Differential Revision: D68143287

fbshipit-source-id: b37abc66c6ce384c6e7ca1d34981082ab7288c94
  • Loading branch information
Georges Berenger authored and facebook-github-bot committed Jan 14, 2025
1 parent 6b6ae79 commit 96c2c05
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vrs/FileCache.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class FileCache {
/// Look-up a file in the cache.
/// @param filename: a filename for the object.
/// @param outFilePath: a path to the object in the cache.
/// @return 0 if the file exists, and outFilePath has bee set.
/// @return 0 if the file exists, and outFilePath has been set.
/// Returns FILE_NOT_FOUND if the file doesn't exist, and outFilePath has been set, for you to
/// add the object in the cache at that location.
/// Returns another error code and outFilePath isn't set, if some error occurred, and the object
Expand Down

0 comments on commit 96c2c05

Please sign in to comment.