Fix vrs hash #134
Closed
Fix vrs hash #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Dec 5, 2024
Summary: Pull Request resolved: facebookresearch#134 Move vrs hash to the latest version of VRS. Differential Revision: D66797878
georges-berenger
force-pushed
the
export-D66797878
branch
from
10585ad to
04d4584
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
georges-berenger
force-pushed
the
export-D66797878
branch
from
04d4584 to
7984ab6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Dec 5, 2024
Summary: Pull Request resolved: facebookresearch#134 X-link: facebookresearch/vrs#168 - fmt::join has been moved in the fmt library from one header to another. We need to include both location to be sure to build in all context and in open source with older and newer versions of fmt. - make sure the vrs hash is current - remove some fb-only includes Differential Revision: D66797878
georges-berenger
force-pushed
the
export-D66797878
branch
from
7984ab6 to
7ac4a69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Dec 5, 2024
Summary: Pull Request resolved: facebookresearch#134 X-link: facebookresearch/vrs#168 - fmt::join has been moved in the fmt library from one header to another. We need to include both location to be sure to build in all context and in open source with older and newer versions of fmt. - make sure the vrs hash is current - remove some fb-only includes - remove annotations from oss Reviewed By: finik Differential Revision: D66797878
georges-berenger
force-pushed
the
export-D66797878
branch
from
7ac4a69 to
3517ca7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
Summary: Pull Request resolved: facebookresearch#134 X-link: facebookresearch/vrs#168 - fmt::join has been moved in the fmt library from one header to another. We need to include both location to be sure to build in all context and in open source with older and newer versions of fmt. - make sure the vrs hash is current - remove some fb-only includes - remove annotations from oss - fix license linter Reviewed By: finik Differential Revision: D66797878
georges-berenger
force-pushed
the
export-D66797878
branch
from
3517ca7 to
0b6b06d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66797878 |
|
This pull request has been merged in bffa874. |
facebook-github-bot
pushed a commit
to facebookresearch/vrs
that referenced
this pull request
Dec 5, 2024
Summary: X-link: facebookresearch/pyvrs#134 Pull Request resolved: #168 - fmt::join has been moved in the fmt library from one header to another. We need to include both location to be sure to build in all context and in open source with older and newer versions of fmt. - make sure the vrs hash is current - remove some fb-only includes - remove annotations from oss - fix license linter Reviewed By: finik Differential Revision: D66797878 fbshipit-source-id: 373948222270d7ccde7779dd9b630a09a9fa56de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move vrs hash to the latest version of VRS.
Differential Revision: D66797878