This repository has been archived by the owner on May 6, 2024. It is now read-only.
Forward wizard mode through nle, add tests. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
heiner
approved these changes
Sep 18, 2020
| @@ -75,25 +75,26 @@ def compare_rollouts(env0, env1, max_rollout_len): | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("env_name", get_nethack_env_ids()) | |||
| @pytest.mark.parametrize("wizard", [False, True]) | |||
There was a problem hiding this comment.
Thanks for the elaborate test!
I'm a little bit reluctant though to double the runtime of the test like this, although obviously it gives optimal test coverage this way. Perhaps we could not add wizard to TestGymEnvRollout?
There was a problem hiding this comment.
I was not sure what wizard-mode affects under the hood, that's why I added the option. I can remove not to increase the testing time.
rockt
approved these changes
Sep 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.