This repository has been archived by the owner on May 6, 2024. It is now read-only.
Prevent use of macro __warn_unused_result__ for M1 Macs, fixing Issue… #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Alternative would be to cherry-pick this: NetHack/NetHack@1302814 |
cdmatters
force-pushed
the
eric/M1-URWARN
branch
from
8e30860 to
aa95f73
Compare
|
Think cherry-pick is the better way to do this. |
cdmatters
force-pushed
the
eric/M1-URWARN
branch
from
aa95f73 to
9980cd0
Compare
heiner
approved these changes
Nov 2, 2022
|
I can confirm that now the following successfully installs |
|
I found the cherry-pick didnt seem to work on Mika's macbook, so reverted the change. Will investigate on my M1, but might just merge this later. |
|
If so, this is a good opportunity to have your code in upstream NH :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #340.