Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Eric/flake patch #335

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Eric/flake patch #335

merged 2 commits into from
Aug 5, 2022

Conversation

cdmatters
Copy link
Contributor

No description provided.

Even though in this case our closures are used only safely in loop, flake8
insists that you code defensively to remove the risk of late-binding closures.

This is a sensible measure, so we bind with partial.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2022
@cdmatters cdmatters requested a review from minqi August 5, 2022 16:01
Copy link
Contributor

@minqi minqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@minqi minqi merged commit 333b5fd into main Aug 5, 2022
@cdmatters
Copy link
Contributor Author

Ta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants