Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Set the terminal emulator to by default not wrap extra long lines, #330

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

cdmatters
Copy link
Contributor

thereby taking a crop of the larger terminal screen.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2022
@cdmatters cdmatters force-pushed the eric/wrap-terminal branch from 01e2ade to 9bdddf1 Compare June 16, 2022 13:44
@cdmatters cdmatters requested a review from tscmoo June 16, 2022 13:47
@cdmatters
Copy link
Contributor Author

This was tested manually:
BEFORE
Screenshot 2022-06-16 at 14 48 15

AFTER
Screenshot 2022-06-16 at 14 46 20

@heiner
Copy link
Contributor

heiner commented Jun 16, 2022

I think this is what the distinction of rendered terminal size vs cropped terminal size was for? But this here works too.

ttyrecs, thereby taking a crop of the larger terminal screen.
@cdmatters cdmatters force-pushed the eric/wrap-terminal branch from 9bdddf1 to 9bc38bc Compare June 16, 2022 13:53
@cdmatters
Copy link
Contributor Author

I think this is what the distinction of rendered terminal size vs cropped terminal size was for? But this here works too.

This is precisely what that was for (I mentioned this to @tscmoo), but this method is a little more memory efficient, and involves fewer parameters.

Copy link
Contributor

@tscmoo tscmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup nice this is pretty much what i was testing locally

performed to see that the ttyrec was indeed trying to wrap.
@cdmatters cdmatters merged commit 5ea9851 into main Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants