Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Make an easier import structure for nethack dataset. #325

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Make an easier import structure for nethack dataset. #325

merged 3 commits into from
Jun 9, 2022

Conversation

cdmatters
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@cdmatters cdmatters force-pushed the eric/dataset-imports branch from 9b6f761 to 74fcb23 Compare June 9, 2022 11:53
@cdmatters cdmatters force-pushed the eric/dataset-imports branch from 74fcb23 to 49b6cca Compare June 9, 2022 13:12
@cdmatters cdmatters requested a review from drothermel June 9, 2022 13:53
@cdmatters
Copy link
Contributor Author

The idea is to be able to do simple

import nle.dataset as nld
data = nld.TtyrecDataset("autoascend")
nld.add_nledata_directory(... )

instead of having a lot of imports

@cdmatters cdmatters requested review from tscmoo and minqi June 9, 2022 14:19
minqi
minqi approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@minqi minqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdmatters cdmatters requested a review from samvelyan June 9, 2022 14:25
@cdmatters
Copy link
Contributor Author

Im sad that your review counts for nothing @minqi

tscmoo
tscmoo approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@tscmoo tscmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@cdmatters cdmatters merged commit e24aac5 into main Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@minqi minqi minqi approved these changes

@tscmoo tscmoo tscmoo approved these changes

@drothermel drothermel Awaiting requested review from drothermel

@samvelyan samvelyan Awaiting requested review from samvelyan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdmatters @minqi @tscmoo @facebook-github-bot