Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add def_oc_syms to pynethack.cc #292

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Add def_oc_syms to pynethack.cc #292

merged 2 commits into from
Dec 1, 2021

Conversation

heiner
Copy link
Contributor

@heiner heiner commented Nov 30, 2021

This allows us to generate a names of glyphs as in NetHack/NetHack#634 (comment). For example with this code: https://gist.github.com/c5117ed04851c50744779af81825c899

Heinrich Kuttler added 2 commits November 30, 2021 17:30
Requires the slightly irritating chr in
  from_oc_class(chr(nethack.WAND_CLASS))
but is consistent with mlet, etc.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 30, 2021
@heiner heiner requested a review from samvelyan November 30, 2021 17:27
Copy link
Contributor

@samvelyan samvelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heiner heiner merged commit 3193d1f into main Dec 1, 2021
@heiner heiner deleted the heiner/glyph-names branch December 1, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants