This repository has been archived by the owner on May 6, 2024. It is now read-only.
Update tty tools #283
Merged
Update tty tools #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
heiner
force-pushed
the
heiner/update-ttytools
branch
from
76b7146 to
d008cf9
Compare
added 4 commits
October 28, 2021 19:24
For non-NetHack ttyrecs, the "\033[26;0f" doesn't work very well as it can jump "up", not down. But there's no good way to do this for all situations.
heiner
force-pushed
the
heiner/update-ttytools
branch
from
d008cf9 to
8fcddb3
Compare
added 8 commits
October 28, 2021 19:48
Also support -1 flag for classic ttyrecs.
As the comment says, could also only start rendering from the last CLRSCREEN before FLAGS.start, which would be potentially faster. The logic to do that requires introducing a few extra modes and does not seem worth it at this point. The logic here is subtle enough as it is.
cdmatters
approved these changes
Nov 2, 2021
| data = chr(char).encode("ascii", "backslashreplace") | ||
| arrow = "->" | ||
|
|
||
| data = str(data)[2:-1] # Strip b' and ' |
There was a problem hiding this comment.
probably better to use a more 'proper' way of doing this that doesnt depend on how Python decides to represent a converted bytes to string?
There was a problem hiding this comment.
I agree! But what is the proper way of doing exactly that? It's not data.encode("ascii", "backslashreplace") ...
There was a problem hiding this comment.
StackOverflow seems to suggest doing what we are doing here ... https://stackoverflow.com/questions/54889234/how-to-decode-a-string-representation-of-a-bytes-object
There was a problem hiding this comment.
|
Im just testing it out and will add some screen shots to the PR |
|
|
cdmatters
reviewed
Nov 2, 2021
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.