This repository has been archived by the owner on May 6, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #269 to fix #272.
The most recent version of gym wraps environments with the
OrderEnforcing
wrapper (https://github.com/openai/gym/blob/master/docs/wrappers.md) if not disabled. This breaks our tests,play.py
and a number of other places. For instance,env.seed()
with more than 1 argument now also fails due togym.Wrapper.seed
. Possible fixes:env.unwrapped
when arguments toseed
are givenOrderEnforcing
wrapper. This will break NLE when using earlier versions of the gym library unless we do per-version magic (as in this PR). We cannot test for the presence ofOrderEnforcing
as it's not exported intogym.wrappers
(sigh).seed(self, (core, disp, reseed))
instead ofseed(self, core=None, disp=None, reseed=False)
.We also use
env._actions
a bunch of times, in tests and inplay.py
. We should fix that, and other accesses to_underscored
variables.