Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Remove space_dict argument to NLE. #261

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove space_dict argument to NLE. #261

merged 1 commit into from
Nov 3, 2021

Conversation

heiner
Copy link
Contributor

@heiner heiner commented Sep 24, 2021

(Should not be merged before the end of the NetHack competition.)

This removes the as-far-as-I-know unused space_dict argument to the NLE class.

For a brief discussion, see e859729#commitcomment-56904804

@heiner heiner requested a review from samvelyan September 24, 2021 09:57
@heiner heiner added the breaking change Introduces a breaking change in API label Sep 24, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2021
samvelyan
samvelyan approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@samvelyan samvelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Doesn't break anything on the minihack's side.

@heiner heiner marked this pull request as ready for review November 3, 2021 18:28
@heiner heiner merged commit 82bba59 into main Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samvelyan samvelyan samvelyan approved these changes

Assignees
No one assigned
Labels
breaking change Introduces a breaking change in API CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heiner @samvelyan @facebook-github-bot