This repository has been archived by the owner on May 6, 2024. It is now read-only.
Add condition mask to blstats observation. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
As a bitset, this isn't exactly ML-friendly. One way of using this: |
cdmatters
reviewed
Jul 19, 2021
There was a problem hiding this comment.
Looks all very straightforward and from a code elegance point of view I woould go with this solution, but it does mean that every single person (pretty much) will implement their own 'factorisation' themselves....
What are the best reasons for not just adding 13 items to the blstats vector?
|
Added constants for the blstats indices, PTAL. I'd rather not add 13 more entries to blstats tbh. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or'd combination of https://github.com/facebookresearch/nle/blob/master/include/botl.h#L57.
This implements #215.