This repository has been archived by the owner on May 6, 2024. It is now read-only.
Fix blstats, again, again #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced by dropping the "time" option.
facebook-github-bot
added
the
CLA Signed
|
Thanks @heiner for the quick fix. I can confirm that the PR resolves the issue on the MiniHack side, where we originally noticed the issue. |
cdmatters
approved these changes
Jul 8, 2021
Thanks for noticing. I wish we could unittest this better. Perhaps that's a reason to turn seed manipulation on again and try out specific trajectories (although there's no guarantee as the RNG is still OS dependent ...) |
|
Update: Pushed a change to |
cdmatters
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write moves / time every normal step.
This fixes a bug introduced by dropping the "time" option.
Hopefully fixes #195.